Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

366 fe implement delete tag functionality #425

Merged
merged 14 commits into from
Aug 5, 2024

Conversation

petark7
Copy link
Member

@petark7 petark7 commented Jul 16, 2024

Implement tag deletion functionality.

petark7 added 3 commits July 15, 2024 15:26
Implement <AddTag> component
- rename <AddTags> to <TagManagementControls> for clarity
- move <ToastContainer> from <ContactForm> to layout.tsx
- minor UI modifications for better UX
- lift handleDelete to parent
- implement delete functionality via modal
@petark7 petark7 requested a review from edichoska July 16, 2024 19:31
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 8:53am

Copy link
Contributor

@edichoska edichoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set up a base branch for all the tags functionality.
you will make PRs toward that branch and in the end we will merge the base branch to staging.
It would be better to just see the changes regarding the ticket on the branch.

petark7 added 5 commits August 3, 2024 23:04
Implement <AddTag> component
- rename <AddTags> to <TagManagementControls> for clarity
- move <ToastContainer> from <ContactForm> to layout.tsx
- minor UI modifications for better UX
- lift handleDelete to parent
- implement delete functionality via modal
- remove unrelated functionality (the add functionality)
- translate to Macedonian
- remove AddTag functionality
petark7 added 5 commits August 4, 2024 10:41
Implement <AddTag> component
- rename <AddTags> to <TagManagementControls> for clarity
- move <ToastContainer> from <ContactForm> to layout.tsx
- minor UI modifications for better UX
- lift handleDelete to parent
- implement delete functionality via modal
- remove AddTag functionality
@petark7 petark7 linked an issue Aug 4, 2024 that may be closed by this pull request
@petark7 petark7 changed the base branch from staging to feature/tags-base August 4, 2024 09:08
@petark7 petark7 requested a review from edichoska August 4, 2024 09:08
@petark7
Copy link
Member Author

petark7 commented Aug 4, 2024

Rebase to feature/tags-base completed.

@petark7 petark7 merged commit ee0324a into feature/tags-base Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] Implement Delete Tag Functionality
2 participants