#386 add tags component #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edichoska
reviewed
Jul 20, 2024
edichoska
requested changes
Jul 20, 2024
edichoska
requested changes
Jul 20, 2024
Comment on lines
34
to
44
| const addTag = (tag: string) => { | ||
| if (!selectedTags.includes(tag)) { | ||
| setSelectedTags([...selectedTags, tag]); | ||
| } | ||
| setSearchTag(''); | ||
| setFilteredTags([]); | ||
| }; | ||
|
|
||
| const removeTag = (tag: string) => { | ||
| setSelectedTags(selectedTags.filter((item) => item !== tag)); | ||
| }; |
There was a problem hiding this comment.
To avoid issues with stale state, we should use the snapshot of the most recent state. something like: setSelectedTags((prevTags) ....
| }; | ||
|
|
||
| return ( | ||
| <div className={styles.modalWrapper}> |
There was a problem hiding this comment.
Use the reusable modal here
edichoska
requested changes
Aug 15, 2024
edichoska
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.