Tags page with React Query fetching implementation #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement <AddTag> component - rename <AddTags> to <TagManagementControls> for clarity - move <ToastContainer> from <ContactForm> to layout.tsx - minor UI modifications for better UX
- lift handleDelete to parent - implement delete functionality via modal
- modify with new structure to serve as a base tags functionality - translate to Macedonian - move state to parent component
Implement <AddTag> component - rename <AddTags> to <TagManagementControls> for clarity - move <ToastContainer> from <ContactForm> to layout.tsx - minor UI modifications for better UX
- translate messages to Macedonian - transfer component to own component folder
Implement <AddTag> component - rename <AddTags> to <TagManagementControls> for clarity - move <ToastContainer> from <ContactForm> to layout.tsx - minor UI modifications for better UX
- lift handleDelete to parent - implement delete functionality via modal
- remove unrelated functionality (the add functionality) - translate to Macedonian
…ithub.com/learnhubmk/app into 366-fe-implement-delete-tag-functionality
- remove AddTag functionality
Implement <AddTag> component - rename <AddTags> to <TagManagementControls> for clarity - move <ToastContainer> from <ContactForm> to layout.tsx - minor UI modifications for better UX
- lift handleDelete to parent - implement delete functionality via modal
- remove AddTag functionality
…ithub.com/learnhubmk/app into 366-fe-implement-delete-tag-functionality
- remove unrelated functionality (add/delete) - add ToastContainer in layout - modify TextInput to accept no label - modify TextInput scss to fit table design - modify ReusableTable to accept custom component
Make props editingTagId & renderEditInput optional
…unctionality 366 fe implement delete tag functionality
- implement basic search functionality
- make row height fixed
Fix issue with no results when whitespace is added after keyword + do additional code changes for better clarity
Implement tags search functionality
- Make more consistent button styling - Optimize button styling via SCSS - Create a custom style for TextInput to avoid globally affecting the styling
Fetch and display tags from API (currently hardcoded Bearer but to be replaced at a later commit)
edichoska
reviewed
Aug 21, 2024
edichoska
reviewed
Aug 21, 2024
edichoska
reviewed
Aug 21, 2024
Move error handling to query hooks for improved code clarity in component and global error handling.
5 tasks
edichoska
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements the API and allows adding/editing, searching and deleting tags.
Currently, the token is manually added in the ENV file but as soon as the auth implementation is ready, that is to be replaced.
The page is almost complete, only thing missing is a pagination component allowing to switch to different page within the table data.