Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson management: Connect "search experience" components and search results list into update resource side panel display #12987

Open
Tracked by #11888
marcellamaki opened this issue Jan 8, 2025 · 0 comments · May be fixed by #13008
Assignees

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Jan 8, 2025

Overview

As we move towards an MVP of the lesson management side panel, we need to finalize integrating the search results into the side panel for lessons.

Prerequisites

  • Ensure your develop is up to date, and work from the /lessonstemp path

Previous work

The following work has already been completed, and now what is needed is just tying it all together:

  • useSearch() and useBaseSearch() composables have already been implemented in kolibri-common
  • the SearchFiltersPanel has been updated for use in coach, and should already be available within a lessons view
  • the resource selection has been updated, to use the new KCards, and an updated composable that manages the selection state
  • the pattern of using nested/child routes should already support this, but if anything has been lost inadvertently in refactoring/rebasing, this pattern should be extended

Scenarios

The following UX scenarios should be supported:

Description Screenshot
When a user sees their list of search results, re-opening the "search" panel at this point displays the current search state. A user is able to make further refinements of the existing search if they choose to. To clear the search, they should clear chips or "clear all", or they can de-select choices from the search panel if it is open Image
If a user navigates into a folder from their search results, they see all resources within that folder, meaning, it is as if they are navigating the topic tree. The filter is not applied to items within the folder. (This corresponds with the existing experience in learn and may be modified in the future - but we want consistency for now). Essentially, the user is moving to a "tree view". To return to the search, the "back to search results" banner restores the previous view of the search results. Image

Acceptance Criteria

  • User can click on the "search" button to open the search/filters panel
  • the results display a combination of resources and folders, using the updated resource selection card list, built on top of the new KCard
  • User can select resources
  • search results are scoped to the current folder; for example - if a user initiates a search at the initial "manage resource" level, the search includes all available channels. if the user initiates a search in Khan Academy English > Grade 10 > Math, their results includes only matching resources within that folder
  • The "back to search results" navigation header should be implemented
  • proper mobile responsiveness and a11y (including the accordion navigation)

Out of scope

  • Implementing this preview for non-practice resources
@marcellamaki marcellamaki changed the title Connect "search experience" components and search results list into update resource side panel display Lesson management: Connect "search experience" components and search results list into update resource side panel display Jan 14, 2025
@AlexVelezLl AlexVelezLl linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants