Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apacman doesn't support packages with '@' or '+' #3

Closed
lectrode opened this issue Oct 20, 2017 · 0 comments
Closed

apacman doesn't support packages with '@' or '+' #3

lectrode opened this issue Oct 20, 2017 · 0 comments

Comments

@lectrode
Copy link
Owner

Original issue reported here

Current supported package attributes/definitions:
https://wiki.archlinux.org/index.php/PKGBUILD#Package_name

When regex mode was implemented, it was made with the assumption that packages did not have these symbols (to be fair, it looks like there is only one package that uses '@', and it is in the official Arch repos). The suggested (accepted?) resolution in the original issue thread is to remove the regex mode entirely.

However, I believe the solution does not have to be that drastic. Instead of supporting Extended Regex, it can be simplified to Basic Regex (see differences here). This would resolve the issue of current unsupported characters, as well as retain the functionality from the original wildcard request.

This seems like another relatively simple change, especially if I introduce static variables to easily define the "valid" characters in the PKGBUILD variables throughout the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant