Solve All this-Binding Problems

[zhzLuke96]

Currently, the code contains many instances of var that = this;

These likely originate from the forked repository, possibly due to an automated JS-to-TS conversion tool.

This can lead to various issues, the most significant being the silent loss of this, which is difficult to detect.

TODOs:

• Remove all occurrences of var that = this; and replace them with arrow functions () => {} wherever applicable.
  • Scope: 13 files, 28 occurrences.
• Address remaining instances of xx = this;
  • These might stem from syntax habits (e.g., var self = this;, which resembles Python-style code but is unnecessary in modern TypeScript).
  • Scope: 17 files, 55 occurrences.
• More aggressively, eliminate all var xxx declarations.
  • var is legacy code and poses potential risks in every line where it appears.
  • Scope: 1182 occurrences. Replace to let them entirely is advisable.