Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to missing files #80

Open
zvedenyuk opened this issue Sep 11, 2021 · 1 comment
Open

Links to missing files #80

zvedenyuk opened this issue Sep 11, 2021 · 1 comment

Comments

@zvedenyuk
Copy link
Contributor

There are some links in <head> to files in images folder that is not in dist:

<html class="notion-html">
<head lang="en">
...
    <link href="/image/https%3A%2F%2Fs3-us-west-2.amazonaws.com%2Fsecure.notion-static.com%2F17843fb5-7467-41c7-b96b-db638f903c3a%2FEugene_Zvedenyuk_1.jpg?table=block&amp;id=37b946f0-1829-42f4-965f-58e2076bc57b&amp;spaceId=4fcefc68-f9c0-4427-b186-180d28820548&amp;width=200&amp;userId=&amp;cache=v2" rel="shortcut icon" type="image/x-icon"/>
    <link href="/images/logo-ios.png" rel="apple-touch-icon"/>
...

And while we're here it actually would be great to place all assets (images, scripts, stylesheets) into separate folder. It would be even better to place internal pages into separate folders for each to get rid of .html in URL.

Something like this:

dist/project1/
  index.html
  assets/
    ...
  page1/
    index.html
  page2/
    index.html
@sueszli
Copy link

sueszli commented Mar 29, 2023

I agree with you - this is why i refactored loconotion and added this feature to my fork: https://github.com/sueszli/notionSnapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zvedenyuk @sueszli