Test failures

[Ovid]

I don't see a way to report issues directly here, so I thought I'd mention some test failures here.

I ran this:

git clean -dfx && ./Configure -des -Dusedevel && make && make test

I get the following test failures:

t/porting/test_bootstrap ......................................... # Failed test 50 - comp/class.t doesn't use use at porting/test_bootstrap.t line 54
#      got '#!./perl\n\nBEGIN {\n    chdir \'t\' if -d \'t\';\n    require \'./test.pl\';\n    set_up_inc(\'../lib\');\n    require Config;\n}\n\nuse v5.36;\nuse feature \'class\';\nno warnings \'experimental::class\';\n\n# class NAME { BLOCK }\n$main::result = \"\";\neval q{\n    $main::result .= \"a(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    class Test1 1.23 {\n        $main::result .= \"b(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    }\n    $main::result .= \"c(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    1;\n} or die $@;\nis($main::result,\n    \"a(main/main)\\n\" .\n    \"b(Test1/Test1)\\n\" .\n    \"c(main/main)\\n\");\nis($Test1::VERSION, 1.23, \'class NAME VERSION { BLOCK } sets $VERSION\');\n\n# class NAME; ...\n$main::result = \"\";\neval q{\n    $main::result .= \"a(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    class Test2 4.56;\n    $main::result .= \"b(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    package main;\n    $main::result .= \"c(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    1;\n} or die $@;\nis($main::result,\n    \"a(main/main)\\n\" .\n    \"b(Test2/Test2)\\n\" .\n    \"c(main/main)\\n\");\nis($Test2::VERSION, 4.56, \'class NAME VERSION; sets $VERSION\');\n\ndone_testing;\n'
# expected !~ /(?^m:^\s*use\s+)/
# Failed test 51 - comp/class.t doesn't use require at porting/test_bootstrap.t line 57
#      got '#!./perl\n\nBEGIN {\n    chdir \'t\' if -d \'t\';\n    require \'./test.pl\';\n    set_up_inc(\'../lib\');\n    require Config;\n}\n\nuse v5.36;\nuse feature \'class\';\nno warnings \'experimental::class\';\n\n# class NAME { BLOCK }\n$main::result = \"\";\neval q{\n    $main::result .= \"a(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    class Test1 1.23 {\n        $main::result .= \"b(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    }\n    $main::result .= \"c(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    1;\n} or die $@;\nis($main::result,\n    \"a(main/main)\\n\" .\n    \"b(Test1/Test1)\\n\" .\n    \"c(main/main)\\n\");\nis($Test1::VERSION, 1.23, \'class NAME VERSION { BLOCK } sets $VERSION\');\n\n# class NAME; ...\n$main::result = \"\";\neval q{\n    $main::result .= \"a(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    class Test2 4.56;\n    $main::result .= \"b(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    package main;\n    $main::result .= \"c(\".__PACKAGE__.\"/\".eval(\"__PACKAGE__\").\")\\n\";\n    1;\n} or die $@;\nis($main::result,\n    \"a(main/main)\\n\" .\n    \"b(Test2/Test2)\\n\" .\n    \"c(main/main)\\n\");\nis($Test2::VERSION, 4.56, \'class NAME VERSION; sets $VERSION\');\n\ndone_testing;\n'
# expected !~ /(?^m:^\s*require\s+)/
FAILED at test 50

And:

t/porting/diag ................................................... # Failed test 34 - Cannot '%s' outside of a 'class' at porting/diag.t line 496                                                                                                                                                                                                                 #     Message 'Cannot '%s' outside of a 'class''                                                                                                                                                                                                                                                                                                                  #     from class.c line 29 is not listed in pod/perldiag.pod
# Failed test 35 - Cannot invoke method on a non-instance at porting/diag.t line 496
#     Message 'Cannot invoke method on a non-instance'
#     from class.c line 155 is not listed in pod/perldiag.pod
# Failed test 572 - Field %s is not accessible outside a method at porting/diag.t line 496
#     Message 'Field %s is not accessible outside a method'
#     from pad.c line 1278 is not listed in pod/perldiag.pod
# Failed test 719 - method at porting/diag.t line 496
#     Message 'method'
#     from perly.act line 341 is not listed in pod/perldiag.pod
# Failed test 720 - ADJUST at porting/diag.t line 496
#     Message 'ADJUST'
#     from perly.act line 375 is not listed in pod/perldiag.pod
# Failed test 721 - TODO: arrange for class seal sometime at porting/diag.t line 496
#     Message 'TODO: arrange for class seal sometime'
#     from perly.act line 414 is not listed in pod/perldiag.pod
# Failed test 746 - field at porting/diag.t line 496
#     Message 'field'
#     from perly.act line 2042 is not listed in pod/perldiag.pod
# Failed test 1884 - ADJUST is experimental at porting/diag.t line 496
#     Message 'ADJUST is experimental'
#     from toke.c line 7805 is not listed in pod/perldiag.pod
# Failed test 1894 - field is experimental at porting/diag.t line 496
#     Message 'field is experimental'
#     from toke.c line 8017 is not listed in pod/perldiag.pod
FAILED at test 34

And:

lib/B/Deparse .................................................... # Failed test 188 - lexical subroutine at ../lib/B/Deparse.t line 96
#      got '{\n    BEGIN {${^WARNING_BITS} = \"\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x54\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\"}\n    my sub f {\n        \n    }\n    print f();\n}'
# expected /(?^:^\{\s*BEGIN\s+\{\$\{\^WARNING_BITS\}\s+\=\s+\"\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x54\\x55\\x55\\x55\\x55\\x55\\x55\\x55\"\}\s+my\s+sub\s+f\s+\{\s+\}\s+print\s+f\(\)\;\s*\}$)/
# =============================================
# CODE:
# --------
#
# no warnings "experimental::lexical_subs";
# my sub f {}
# print f();
# --------
# EXPECTED:
# --------
# {
# BEGIN {${^WARNING_BITS} = "\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x54\x55\x55\x55\x55\x55\x55\x55"}
# my sub f {
#
# }
# print f();
# }
# --------
# GOT:
# --------
# {
#     BEGIN {${^WARNING_BITS} = "\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x54\x55\x55\x55\x55\x55\x55\x55\x55"}
#     my sub f {
#
#     }
#     print f();
# }
# --------
# =============================================
# Failed test 189 - lexical "state" subroutine at ../lib/B/Deparse.t line 96
#      got '{\n    BEGIN {${^WARNING_BITS} = \"\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x54\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\"}\n    state sub f {\n        \n    }\n    print f();\n}'
# expected /(?^:^\{\s*BEGIN\s+\{\$\{\^WARNING_BITS\}\s+\=\s+\"\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x55\\x54\\x55\\x55\\x55\\x55\\x55\\x55\\x55\"\}\s+state\s+sub\s+f\s+\{\s+\}\s+print\s+f\(\)\;\s*\}$)/
# =============================================
# CODE:
# --------
#
# no warnings 'experimental::lexical_subs';
# state sub f {}
# print f();
# --------
# EXPECTED:
# --------
# {
# BEGIN {${^WARNING_BITS} = "\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x54\x55\x55\x55\x55\x55\x55\x55"}
# state sub f {
#
# }
# print f();
# }
# --------
# GOT:
# --------
# {
#     BEGIN {${^WARNING_BITS} = "\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x55\x54\x55\x55\x55\x55\x55\x55\x55\x55"}
#     state sub f {
#
#     }
#     print f();
# }
# --------
# =============================================
FAILED at test 188

I'll try to write some tests (and maybe docs) and push them.

[Ovid]

Also, I tried to open a PR (https://github.com/leonerd/perl5/pull/12/files) to include some tests in t/class/class.t. I only committed one file, but it says over 2,000 files changed. Not sure what I did wrong.

[HaraldJoerg]

@Ovid: It seems that you wrote the PR against leonerd's blead branch

[Ovid]

Gah. One day, one day, I'll learn how to git. Thank you :)