From 21dcc489c3f7718bd929727b9d75c3cf1a977953 Mon Sep 17 00:00:00 2001 From: Ke Xu Date: Wed, 21 Jun 2017 18:34:53 +0900 Subject: [PATCH 1/2] add private option in repo create --- content/modal.html | 9 +++++++++ src/github-api.js | 5 ++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/content/modal.html b/content/modal.html index c3dbc68..d1c1802 100644 --- a/content/modal.html +++ b/content/modal.html @@ -46,6 +46,15 @@
Description
+ +
Type
+
+ +
+ diff --git a/src/github-api.js b/src/github-api.js index c008dab..0dde3cc 100644 --- a/src/github-api.js +++ b/src/github-api.js @@ -282,10 +282,12 @@ function getGithubRepos() { function githubCreateRepo() { const repo = $('#new-repo-name').val(); const desc = $('#new-repo-desc').val(); + const isPrivate = $('#new-repo-type').val() !== 'public'; const payload = { name : repo, description : desc, - auto_init : true + auto_init : true, + private: isPrivate } if (!repo || repo === "") return; new Promise((resolve, reject) => { @@ -322,6 +324,7 @@ function githubCreateRepo() { .then(() => { $('#new-repo-name').val(""); $('#new-repo-desc').val(""); + $('#new-repo-type').val("public"); showAlert(`Successfully create new repository ${repo}`); }) .catch((err) => { From 7accbb3b14afbf63a67780bc1658d3a6276f5565 Mon Sep 17 00:00:00 2001 From: Ke Xu Date: Wed, 21 Jun 2017 18:55:08 +0900 Subject: [PATCH 2/2] bump versoin, add deploy step to ci --- Dangerfile | 4 +++- circle.yml | 7 +++++++ manifest.json | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/Dangerfile b/Dangerfile index 95114d2..eb10825 100644 --- a/Dangerfile +++ b/Dangerfile @@ -1,6 +1,8 @@ warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]" warn("Big PR, try to keep changes smaller if you can") if git.lines_of_code > 500 +warn("manifest is not changed, forget to bump version?") if !git.modified_files.include?("manifest.json") +github.dismiss_out_of_range_messages eslint.filtering = true eslint.lint -lgtm.check_lgtm +lgtm.check_lgtm \ No newline at end of file diff --git a/circle.yml b/circle.yml index 4760b3f..091b3b9 100644 --- a/circle.yml +++ b/circle.yml @@ -6,3 +6,10 @@ dependencies: test: override: - danger + +deployment: + production: + branch: master + commands: + - zip -r gas-github.zip . -x 'node_modules/*' -x '\.*' -x 'circle.yml' -x 'Dangerfile' -x 'Gemfile*' + - mv gas-github.zip $CIRCLE_ARTIFACTS \ No newline at end of file diff --git a/manifest.json b/manifest.json index b3b7a37..c34d990 100644 --- a/manifest.json +++ b/manifest.json @@ -1,5 +1,5 @@ { - "version": "2.0.0", + "version": "2.0.1", "manifest_version": 2, "default_locale": "en", "name": "__MSG_appName__",