Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Pseudo-classes selector list report error "Missing closing ')'" #3802

Open
FlareZh opened this issue Jun 21, 2023 · 9 comments
Open
Assignees
Labels

Comments

@FlareZh FlareZh added the bug label Jun 21, 2023
@FlareZh FlareZh changed the title Nested Pseudo-classes report error "Missing closing ')'" Nested Pseudo-classes selector list report error "Missing closing ')'" Jun 21, 2023
@iampaandey
Copy link

Can you please assign this issue to me?

@FlareZh
Copy link
Author

FlareZh commented Jul 10, 2023

Can you please assign this issue to me?

Of course. But it looks like I don't have that permission.

@iampaandey
Copy link

Can i still complete this issue.

@iampaandey
Copy link

@iChenLei can you please exactly tell the line in less.js file from where you take the code from playground ?

@vimal20002
Copy link

@iChenLei can I also work on that me and @iampaandey are peer programmer please assign it to me also ! ;)

@iampaandey
Copy link

Can you also please elaborate little bit @matthew-dean ?

@matthew-dean
Copy link
Member

@iampaandey I think the issue is here. It looks like the parser is a little naive, in that it allows any parenthetical (I think) after a selector, but then, within that parenthetical, it only accepts a single selector (this.selector vs this.selectors)

@puckowski
Copy link
Contributor

I believe #4290 may fix this issue.

The following Less.js:

:not(:has(div), div, h) {
    background: red;
    width: 100px;
    height: 100px;
}

becomes:

:not(:has(div), div, h) {
  background: red;
  width: 100px;
  height: 100px;
}

I tested using https://github.com/puckowski/less.js/releases/tag/4.2.1.2

Fork release is Less.js 4.2.1 with fixes for:
#4252
#3737
#4258
#4264
#4268
#4267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants
@matthew-dean @puckowski @FlareZh @ivan-sapeha @vimal20002 @iampaandey and others