Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dynamic property creation due to JsonMapperHelper #531

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jeremy379
Copy link
Contributor

@jeremy379 jeremy379 commented Mar 26, 2024

Fix issue reported in #530

Fixed

  • Check if property is is set in object before assigning it, this prevents failure when dynamically setting property in php8.2

@jeremy379 jeremy379 force-pushed the fix-jsdPublic-dynamic-property branch 2 times, most recently from c9f3792 to 1156038 Compare March 27, 2024 16:26
@jeremy379 jeremy379 changed the title Add jsdPublic property Prevent dynamic assignation Mar 27, 2024
@jeremy379 jeremy379 changed the title Prevent dynamic assignation Prevent dynamic property creation due to JsonMapperHelper Mar 27, 2024
@jeremy379 jeremy379 force-pushed the fix-jsdPublic-dynamic-property branch from 1156038 to 67c8307 Compare March 27, 2024 16:27
@durimjusaj
Copy link

@jeremy379 I have same problem with deprecated Exceptions.

Deprecated: Creation of dynamic property JiraRestApi\Project\Project::$uuid is deprecated
Deprecated: Creation of dynamic property JiraRestApi\Project\Project::$entityId is deprecated

@lesstif lesstif merged commit 83d4f8d into lesstif:main Apr 22, 2024
2 of 3 checks passed
@jeremy379 jeremy379 deleted the fix-jsdPublic-dynamic-property branch April 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants