From 65de9fb4b8b2086e7bcbf205854b6cf161e5982d Mon Sep 17 00:00:00 2001 From: Samantha Frank Date: Tue, 19 Nov 2024 14:14:34 -0500 Subject: [PATCH] VA: Fix two IsCAAValid bugs (#7829) Fix two bugs introduced in #7816: - Fix localLatency time for CAA rechecking is always 0 - Fix logEvent.InternalError is no longer being written to log --- va/caa.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/va/caa.go b/va/caa.go index da35eb2f4bd..085471623f8 100644 --- a/va/caa.go +++ b/va/caa.go @@ -90,7 +90,12 @@ func (va *ValidationAuthorityImpl) IsCAAValid(ctx context.Context, req *vapb.IsC } internalErr = va.checkCAA(ctx, acmeID, params) + + // Stop the clock for local check latency. + localLatency = va.clk.Since(start) + if internalErr != nil { + logEvent.InternalError = internalErr.Error() prob = detailedError(internalErr) prob.Detail = fmt.Sprintf("While processing CAA for %s: %s", req.Domain, prob.Detail) } else if remoteCAAResults != nil {