Removed imp and changed import calls in pysnmp/smi/builder.py #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… import (https://discuss.python.org/t/python3-11-importlib-no-longer-exposes-util/25641/10). Removed alternative way to get PY_MAGIC_NUMBER, SOURCE_SUFFIXES and BYTECODE_SUFFIXES in pysnmp/smi/builder.py via imp module because it was removed in Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html)
lextm
added a commit
that referenced
this pull request
Jan 12, 2024
|
While you pointed out the issue with Python 3.12, the fix proposed isn't the best (might break old Python versions). |
|
Used another way to fix it in latest release 5.0.33. You might take a look there. |
lextm
added a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed imports of importlib.util and importlib.machinery to explicit import (https://discuss.python.org/t/python3-11-importlib-no-longer-exposes-util/25641/10).
Removed alternative way to get PY_MAGIC_NUMBER, SOURCE_SUFFIXES and BYTECODE_SUFFIXES in pysnmp/smi/builder.py via imp module because it was removed in Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html)