Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue number rewriting shouldn't rewrite file attachments #101

Open
GoogleCodeExporter opened this issue Sep 14, 2015 · 0 comments
Open

Comments

@GoogleCodeExporter
Copy link

Issue number rewriting shouldn't rewrite file attachments. If there is a file 
attachment named "issue1234.patch" we shouldn't rewrite that as 
"issue4567.patch" to match GitHub. Instead, we should keep it as-is since 
otherwise the links will be invalid.

See:
https://github.com/firebug/firebug/issues/5234#issuecomment-103495972.

Which actually corresponds to:
http://storage.googleapis.com/google-code-attachments/fbug/issue-5096/comment-2/
issue5096.patch
http://storage.googleapis.com/google-code-attachments/fbug/issue-5096/comment-4/
Issue5096.patch

Original issue reported on code.google.com by [email protected] on 18 Jun 2015 at 4:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant