Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the color of the focus ring with the brand color #632

Open
MH4GF opened this issue Jan 31, 2025 · 2 comments
Open

Unify the color of the focus ring with the brand color #632

MH4GF opened this issue Jan 31, 2025 · 2 comments
Assignees
Labels

Comments

@MH4GF
Copy link
Member

MH4GF commented Jan 31, 2025

🎯 Background and Purpose

Example: Sidebar

Steps to Reproduce

  1. Click on a table name in the sidebar, then press the Tab key to move to the table below.
  2. A focus ring appears.

Image

Since the focus ring uses the default browser/OS color, we want to align it with Liam's brand colors.


📝 Task Overview

Modify the focus ring for buttons displayed in Liam ERD as follows:

:focus-visible {
  outline: var(--primary-color) auto 1px;
}

LeftPane

Image

TableDetail

Image


💬 Points to Consider

Since there are other buttons, such as in the toolbar, we need to identify all of them and apply the update universally.


⚽ Goal

Ensure that all focus rings for buttons displayed in Liam ERD use the brand color.


💡 References

@JonathanDeLaCruzEncora
Copy link

Hi I tried to give it a go to this issue, if there are any changes to be done in the PR, let me know, specially because I wasn't able to see the pictures attached to this issue.

However, I followed your instructions and was able to see the focus ring, and changed also the ones at the toolbar, so if there are others missing or need any changes, I'd be happy to help.

@MH4GF
Copy link
Member Author

MH4GF commented Feb 3, 2025

Hi @JonathanDeLaCruzEncora, thanks for your contribution ✨ And sorry, I was using the wrong attachment way.
You have done what we wanted to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants