Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad versionsing of dependencies in package.json #1

Open
brettcave opened this issue Jan 30, 2014 · 1 comment
Open

Bad versionsing of dependencies in package.json #1

brettcave opened this issue Jan 30, 2014 · 1 comment

Comments

@brettcave
Copy link

If a version is not specified in package.json of customer.io (specifically the "coffee-script" dependency), then the latest available version will be used.

Coffee-script 1.7.1 has been published to NPM, and this is breaking customer.io 0.0.2. Previously, coffee-script 1.6.3 was being used, and worked. The error is found when requiring customer.io:

 Error: Cannot find module './src'
   at Function.Module._resolveFilename (module.js:338:15)
   at Function.Module._load (module.js:280:25)
   at Module.require (module.js:364:17)
   at require (module.js:380:17)
   at Object.<anonymous> (/project/node_modules/customer.io/index.js:2:18)

By locking down the major dependency version in package.json, API changes in major dependency releases will not break customer.io. Use the following in package.json:

"coffee-script" : "1.6.x"
@brettcave
Copy link
Author

Until the change is published to npm, other customer.io users can use the following dependency in package.json:

"dependencies" : { "customer.io" : "git://github.com/brettcave/node-customer.io.git" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant