Merge pull request #1426 from evoskuil/master

Comments.

include/bitcoin/system/chain/context.hpp

@@ -30,7 +30,7 @@ namespace chain {
 class BC_API context final
 {
 public:
-    /// Determine if the fork is ative for this block.
+    /// Determine if the fork is active for this block.
     bool is_enabled(chain::forks fork) const NOEXCEPT;
 
     /// Header context within chain.

src/chain/block.cpp

@@ -686,6 +686,11 @@ code block::check() const NOEXCEPT
     return check_transactions();
 }
 
+// forks
+// height
+// timestamp
+// median_time_past
+
 code block::check(const context& ctx) const NOEXCEPT
 {
     const auto bip34 = ctx.is_enabled(bip34_rule);
@@ -705,6 +710,9 @@ code block::check(const context& ctx) const NOEXCEPT
     return check_transactions(ctx);
 }
 
+// forks
+// height
+
 // This assumes that prevout caching is completed on all inputs.
 code block::accept(const context& ctx, size_t subsidy_interval,
     uint64_t initial_subsidy) const NOEXCEPT
@@ -722,6 +730,8 @@ code block::accept(const context& ctx, size_t subsidy_interval,
     return accept_transactions(ctx);
 }
 
+// forks
+
 // Node performs these checks through database query.
 // This assumes that prevout and metadata caching are completed on all inputs.
 code block::confirm(const context& ctx) const NOEXCEPT
@@ -734,6 +744,8 @@ code block::confirm(const context& ctx) const NOEXCEPT
     return confirm_transactions(ctx);
 }
 
+// forks
+
 code block::connect(const context& ctx) const NOEXCEPT
 {
     return connect_transactions(ctx);

src/chain/header.cpp

@@ -333,6 +333,10 @@ code header::check(uint32_t timestamp_limit_seconds,
     return error::success;
 }
 
+// minimum_block_version
+// median_time_past
+// work_required
+
 // Checkpoints and previous_block_hash are chain validation (not here).
 // bits_ below is the consensus direct comparison of the header.bits value.
 // All other work comparisons performed on expanded/normalized bits values.

src/chain/transaction.cpp

@@ -1255,6 +1255,11 @@ code transaction::check() const NOEXCEPT
     return error::transaction_success;
 }
 
+// forks
+// height
+// timestamp
+// median_time_past
+
 // DO invoke on coinbase.
 code transaction::check(const context& ctx) const NOEXCEPT
 {
@@ -1282,6 +1287,10 @@ code transaction::accept(const context&) const NOEXCEPT
     return error::transaction_success;
 }
 
+// forks
+// height
+// median_time_past
+
 // Do NOT invoke on coinbase.
 // Node performs these checks through database query.
 // This assumes that prevout and metadata caching are completed on all inputs.
@@ -1307,6 +1316,8 @@ code transaction::confirm(const context& ctx) const NOEXCEPT
 // Connect (contextual).
 // ----------------------------------------------------------------------------
 
+// forks
+
 // Do NOT invoke on coinbase.
 code transaction::connect(const context& ctx) const NOEXCEPT
 {