Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting write_html.py #14

Open
ghost opened this issue Oct 9, 2019 · 3 comments
Open

Restricting write_html.py #14

ghost opened this issue Oct 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 9, 2019

I think it would be nice to run something like this:

./fetch_links.py linux 2018-01-01 2018-12-31
./write_html.py linux 2018-01-01 2018-12-31

The first command already works fine, but the second one doesn't.

Unfortunately running ./write_html.py without arguments requires too much memory on my system and takes too long. After more than 30 minutes I had to manually stop it.

Being able to process posts from just one single subreddit in a limited time interval would probably help.

@libertysoft3
Copy link
Owner

So I see two issues here, the RAM issue and the issue of wanting to output a particular subreddit with write_html.py. Do you want to output multiple subs eventually? The issue is that write_html.py wants to know all of the subs that will be written, so it can create the index.html page as well as the 'subreddits' dropdown in the menu bar.

If you want to output multiple subs, then fixing the RAM issue would be the simplest and most straightforward way to move forward.

Maybe you can add some logging statements with memory used and figure out where it's going wrong? How big is all of your data in 'data'?

@libertysoft3 libertysoft3 added the bug Something isn't working label Oct 10, 2019
@ghost
Copy link
Author

ghost commented Oct 10, 2019

The best thing would be to fix the RAM issue, if possible, eventually keeping write_html.py usage as currently is. In my test write_html.py used all 8 gigabytes of RAM plus 5 gigabytes of swap before I stopped it. My data directory is currently 3.1 gigabytes. It will continue to expand in the future because I'm always adding new subreddits. Should I create another issue specifically for my RAM issue?

@libertysoft3
Copy link
Owner

Ugh, yeah something is definitely wrong there with that RAM usage. Yeah let's make a new RAM fail issue. I'll try to fix that RAM thing sometime. I'll change this one to an 'enhancement'.

@libertysoft3 libertysoft3 added enhancement New feature or request and removed bug Something isn't working labels Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant