Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webrtc): increase max message size to 256kiB #5589

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat(webrtc): increase max message size to 256kiB #5589

wants to merge 7 commits into from

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Sep 3, 2024 •
edited
Loading

Description

Increasing WebRTC max message size from 16 kiB to 256 kiB after fix browser bugs.

Context: libp2p/specs#628

Notes & open questions

To be merged after libp2p/specs#628 is merged.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@guillaumemichel guillaumemichel mentioned this pull request Sep 3, 2024
Draft
jxs
jxs approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Gui!

dariusc93
dariusc93 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we make this a draft until the spec has been updated to prevent this from being merged by mistake?

@jxs jxs marked this pull request as draft September 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumemichel @jxs @dariusc93