Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): update deny.toml to ignore RUSTSEC-2024-0384 #5702

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ci): update deny.toml to ignore RUSTSEC-2024-0384 #5702

wants to merge 2 commits into from
+2 −1

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 28, 2024 •
edited
Loading

Description

Ignore RUSTSEC-2024-0384 in deny.toml to let CI pass.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 marked this pull request as ready for review November 28, 2024 09:22
@drHuangMHT
Copy link
Contributor

cargo-deny test is not required to merge a PR, I don't think this is necessary.

@jxs
Copy link
Member

jxs commented Nov 29, 2024

Thanks for this @hanabi1224, and for your work on rust-netlink/netlink-sys#25!
I agree with @drHuangMHT I'd rather have CI red and confronting/recalling us to act (deprecating async-std) than silently ignore this issue.

@maqi maqi mentioned this pull request Nov 29, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @drHuangMHT @jxs