Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SC Controller as an UI reference #329

Open
DFOXpro opened this issue Mar 24, 2019 · 5 comments
Open

Add SC Controller as an UI reference #329

DFOXpro opened this issue Mar 24, 2019 · 5 comments

Comments

@DFOXpro
Copy link

DFOXpro commented Mar 24, 2019

Problem

In the UI guideline reference (Wiki:Piper Redesign) there is no GTK3 base applications to take in mind within the design.

Possible solution

Add other gamer related drivers UI like SC-Controller to the guidelines

What it possibly solve

in the beginning it can "solve" the lack of impact of the mouse image in the window (accesability high contrast guidelines), or inspire towards the clickable SVG issue

Example

With this in mind

ca

Before

Capture du 2019-03-24 11-23-47

After

Capture du 2019-03-24 11-47-05

Source Impact

First the wiki should be updated, also including a colour pallet and css classes for onhover svg buttons.
The mice images should be normalized with a well defined color pallet.

How to continue

  • How can I(we?) pull request a change in your wiki?
  • Can I edit your SVGs?
  • In which branch should be point the pull request?
@whot
Copy link
Member

whot commented Mar 25, 2019

Sorry, i'm not sure what the actual issue is here, can you please edit this to make it clearer?

@DFOXpro
Copy link
Author

DFOXpro commented Mar 26, 2019

Sorry, i'm not sure what the actual issue is here, can you please edit this to make it clearer?

this is an enhancement issue (to the UI and specially the documentation); It's related maybe to:

  • very low contrast mice images (an accesability issue)
    and the current [Make the buttons in the SVG clickable for configuration ]

@whot
Copy link
Member

whot commented Mar 27, 2019

Do you happen to know what the the normal way is GNOME deals with high-contrast issues? We could recolour the SVG on the fly I guess but it'd be good if there was some system-wide setting we can query and/or use. Any actual SVG changes I'd rather run past the GNOME designers to get their sign-off so we don't end up doing work we have to re-do again later.

The wiki page itself is only there for archive reasons, so it's kept as-is in case we need to remember why we did something. For any future changes, having a bug specifically describing what you want to add is better.

@hipnoizz
Copy link

In regards to SVG buttons being clickable - I think there was already some discussion about it and Piper devs decided against it. I can't find the relevant ticket though.

@Hjdskes
Copy link
Member

Hjdskes commented Mar 28, 2019

Piper devs decided against it.

No we didn't, see #71 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants