Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubus-lime-utils uses watchping but does not depend on it and should check for client-wwan before running #956

Open
ilario opened this issue Dec 7, 2022 · 2 comments · May be fixed by #1143
Open

ubus-lime-utils uses watchping but does not depend on it and should check for client-wwan before running #956

ilario opened this issue Dec 7, 2022 · 2 comments · May be fixed by #1143
Assignees
@germanferrero
Labels
bug easy to solve
Milestone
2024.1

Comments

@ilario
Copy link
Member

ilario commented Dec 7, 2022

As commented here #927 (comment) the ubus-lime-utils package uses watchping here:

lime-packages/packages/ubus-lime-utils/files/etc/udhcpc.user

Line 11 in 400ac95

/etc/init.d/watchping restart

but it does not include it in its dependencies.
This results in the following error:

/usr/share/udhcpc/default.script: /etc/udhcpc.user.d/50-client-wwan-watchping: line 11: /etc/init.d/watchping: not found

Additionally, if udhcpc is run manually, it also complains about the nonexistence of client-wwan interface:

ip: can't find device 'client-wwan'

so that a check should be included for the existence of the interface before proceeding.
@ilario ilario mentioned this issue Dec 8, 2022
Merged
@ilario ilario added this to Releases Feb 23, 2023
@ilario ilario added this to the 2020.2 milestone Feb 23, 2023
@ilario ilario modified the milestones: 2020.2, 2023.1 Apr 7, 2023
@ilario
Copy link
Member Author

ilario commented Nov 7, 2024

Additionally, if udhcpc is run manually, it also complains about the nonexistence of client-wwan interface:

ip: can't find device 'client-wwan'

so that a check should be included for the existence of the interface before proceeding.

The if check should be inserted between these two lines:

lime-packages/packages/ubus-lime-utils/files/etc/udhcpc.user.d/50-client-wwan-watchping

Lines 2 to 3 in 08a3948

ifname="client-wwan"
gw=$(ip r show default dev $ifname | while read default via ip rest; do [[ $via == "via" ]] && echo $ip && break; done)

@ilario
Copy link
Member Author

ilario commented Nov 7, 2024

@spiccinini you are indicated as the maintainer of this package, are you still interested in maintaining it? Can you fix this issue?

@ilario ilario added the bug label Nov 7, 2024
@ilario ilario modified the milestones: 2025.1, 2024.1 Nov 16, 2024
@ilario ilario linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germanferrero germanferrero

Labels
bug easy to solve
Projects
Releases
Status: No status
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

Fixes on ubus-lime-utils ilario/lime-packages
2 participants
@ilario @germanferrero