Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotplug-initd-observer error #1064

Open
ilario opened this issue Nov 17, 2023 · 2 comments · May be fixed by #1148
Open

hotplug-initd-observer error #1064

ilario opened this issue Nov 17, 2023 · 2 comments · May be fixed by #1148
Assignees
@G10h4ck
Labels
bug easy to solve good first issue
Milestone
2024.1

Comments

@ilario
Copy link
Member

ilario commented Nov 17, 2023

Observed the logs shared by @LaneaLucy in LibreMesh chat:


Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: /usr/bin/lua: /usr/bin/hotplug-initd-observer:13: bad argument #3 to 'format' (string expected, got nil)
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: stack traceback:
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: 	[C]: in function 'format'
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: 	/usr/bin/hotplug-initd-observer:13: in function </usr/bin/hotplug-initd-observer:10>
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: 	[C]: in function 'run'
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: 	/usr/bin/hotplug-initd-observer:23: in main chunk
Fri Apr 28 09:41:28 2023 daemon.err hotplug-initd-observer[11153]: 	[C]: ?
Fri Apr 28 09:41:30 2023 daemon.err hostapd: rmdir[ctrl_interface=/var/run/hostapd]: Permission denied
Fri Apr 28 09:41:35 2023 daemon.err babeld[2223]: send: Address not available
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: /usr/bin/lua: /usr/bin/hotplug-initd-observer:13: bad argument #3 to 'format' (string expected, got nil)
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: stack traceback:
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: 	[C]: in function 'format'
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: 	/usr/bin/hotplug-initd-observer:13: in function </usr/bin/hotplug-initd-observer:10>
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: 	[C]: in function 'run'
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: 	/usr/bin/hotplug-initd-observer:23: in main chunk
Fri Apr 28 09:41:38 2023 daemon.err hotplug-initd-observer[31750]: 	[C]: ?
@pony1k pony1k mentioned this issue Jan 25, 2024
Closed
@ilario
Copy link
Member Author

ilario commented Nov 7, 2024

As inspected by @pony1k in #1068, this error happens when evData.service is nil.
A possible solution is to replace evData.service with evData.service or '' in this line (untested):

lime-packages/packages/hotplug-initd-services/files/usr/bin/hotplug-initd-observer

Line 14 in 5a50b6f

evName, evData.service, hooksDir, hook ) )

@ilario
Copy link
Member Author

ilario commented Nov 7, 2024

Seems that that SERVICE variable is used only here:

lime-packages/packages/shared-state-babeld_hosts/files/etc/hotplug.d/initd/shared-state-babeld_hosts

Line 6 in 08a3948

[ "$SERVICE" == "babeld" ] && [ "$ACTION" == "service.start" ] &&

@ilario ilario added this to Releases Nov 16, 2024
@ilario ilario added this to the 2024.1 milestone Nov 16, 2024
@ilario ilario linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G10h4ck G10h4ck

Labels
bug easy to solve good first issue
Projects
Releases
Status: No status
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

hotplug-initd-observer: Avoid format error when evData.service is empty ilario/lime-packages
2 participants
@G10h4ck @ilario