-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last Bronx (USA) - CHD does not load properly #162
Comments
I have now tried the 4 existing versions of this game, only Japan Disc1 loads in CHD format, all the other ones fail in pretty much the same way, with Japanese Disc2 failing harder for whatever reason:
In all the four versions above, both formats load correctly in all other Sega Saturn cores (YabaSanshiro, Yabause, Kronos). Info from remaining CHDs Last Bronx (Europe)
Last Bronx (Japan) (Disc 1) (Arcade Disc)
Last Bronx (Japan) (Disc 2) (Special Disc)
|
@rtissera , @twinaphex would appreciate if you guys could look at the CHD implementation in this core, seems it has some quirks that prevent some games from loading, the one mentioned in this issue's title being the one I've come across thus far. I think the issue is not the medium, but you guys could confirm that. I can also help with testing and debugging if needed. |
I will try to have a look, it's a very narrow issue. |
Thanks. Apart from that, Kronos and YabaSanshiro have no issue at all with any game or CHD compression type from my tests; weirdly enough Yabause hangs at boot with an uncompressed CHD of Last Bronx (USA/EUR), but will not hang with a compressed one or uncompressed CHD of any other game I tested, as I mentioned in issue #163 Thanks in advance. EDIT: |
Now that's get interesting.... |
That is very interesting indeed... so the explains why uncompressed hunks won't work, that could be just tagged as an enhancement and left for later, but if you're right then the lack of uncompressed hunk support is the reason why the CHD isn't loading. In other words, the Japanese version works just because the size happened to fit the compression and no seemingly important data was left uncompressed. |
None of it is uncompressed. You can verify with your own by adding -v to your info check. That said, for most games only the first track is data, not the first two (indeed, for every other game I personally have). It could be related to that. The only system where I've seen multiple data tracks often is Dreamcast, and from what I've been told (but haven't tested), cue-based chds won't function, while gdi-based chds will. Based on that, I would assume cue chds and multiple data tracks don't get along for some unknown reason. Could be as simple as a cuefile tweak to fix it if so, if we knew what caused that. Last Bronx track 2:
Radiant Silvergun track 2 for comparison:
|
@Sanaki That's interesting, but there are two questions that are not answered by that theory:
Last Bronx (Japan) (Disc 1) (Arcade Disc) - track 2:
JAP CHD verbose output:
|
No idea. I'm just saying that's the only thing I see myself that's particularly unique and relates to the chd format. Since the jp version has the same trait and doesn't exhibit the same behavior, figuring out what sets them apart should help answer that, but I have no answer myself. |
Sure, I understand. Just for testing I swapped the last 22 out of 24 tracks from the US version with JP's, BIN/CUE still work, CHD still doesn't. All the data is still in tracks 1 and 2, swapping one and not the other will glitch the boot, changing the disc region does not change anything either. US version has 142 more files in track1; 3 main EXEs different in content and a 4th EXE not present in the JP version, the rest is the same. track2 I don't know what's the format and its contents, but that's where the bulk of data is and the US version is some 15MB bigger. Anyway, this isn't helpful at all, just some curiosity. |
libchdr was recently updated for the Saturn core in https://github.com/libretro/beetle-saturn-libretro/pull/171 Could you test to see if it solves the issue? |
issue is probably similar to this: https://github.com/libretro/beetle-saturn-libretro/issues/163 libretro/beetle-pce-fast-libretro#163 @rtissera whats the test case for the alignment issue? i see this only change lzma and flac, but i cant remember chd issue related to those, at least for pce disks and psx (pcsx). i mainly compressed files with cdlz, nothing else. |
I am on it
Le mar. 3 nov. 2020 à 12:57, negativeExponent <[email protected]> a
écrit :
… issue is probably similar to this: #163
<https://github.com/libretro/beetle-saturn-libretro/issues/163>
we need the whole thing from libchdr updated.
@rtissera <https://github.com/rtissera> whats the test case for the
alignment issue? i see this only change lzma and flac, but i cant remember
chd issue related to those, at least for pce disks and psx (pcsx). i mainly
compressed files with cdlz, nothing else.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/libretro/beetle-saturn-libretro/issues/162#issuecomment-721072917>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4WBOXZR3QKNQAQORSM6LSN7V3LANCNFSM4K4QXQOQ>
.
|
On a whim, I did try updating to the newest libchdr. No change from that. |
I have not had this issue with RetroARch freezing. So far the only actual issue I had was RA 1.9.1 screwing CG shader support accross the board. The game does get stuck after the boot logo at a black screen with Yabause. On Beetle Saturn it still behaves as before, with the blinking red cursor at boot (make sure to delete Saturn RAM files, otherwise it'll just be stuck like Yabause). With Kronos it boots fine but performance is terrible. YabaSanshiro boots fine and is the best emulation for this game at the moment (obviously also accounting for proper CHD loading of this particular game). |
Hmm... the retroarch freeze seems to be another stacked issue. Based on a comment made in the discord server I checked EDIT: It was rewind being enabled. Please disregard the freeze aspect. |
It seems there is an issue with Beetle's CHD support in regards to this particular game.
There is also a chance that it is a bad dump, but so far everything indicates the opposite.The BIN/CUE loads fine, the CHD does not. The CHD loads in every other Sega Saturn core except for Beetle. The dump seems to be trustworthy, partially because it's the same one listed in redumps.org, this one in particular: http://redump.org/disc/51689/I have tried all other redumps (same hashes as the ones in libretro db); the issue is the same in all with the notable exception of the Japanese (disc1) version. In any case, if the CHD is converted back to BIN/CUE it loads fine for every game/region. I don't think this particular issue stands with the dump, and as far as I know there are no other games affected, but then again I have not tested a great deal of CHD derived versions. As it stands, this very narrow issue seems to originate in the core.
Note: First mention of this issue that I could find was over at RetroArch's forum, dating back to April 2018: https://forums.libretro.com/t/bug-in-chd-support-for-beetle-saturn-core/15875
CHD info
Another thing is, if I clear the game memory, I can see that Beetle is (kind of) loading the game, but messes things up in the process, here's an example of what I mean:
BIN/CUE at boot with memory clean
CHD at boot with memory clean (note: the selection rectangle is blinking normally despite having no text on screen, also responds correctly to up/down D-Pad option changes)
I have only tested about a dozen games with Beetle, but this one game seems to show some issue with emulation and CHD support at once, which does not affect other games or cores as far as I know. Logging does not show anything out of the ordinary, the opposite in fact:
The text was updated successfully, but these errors were encountered: