Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xd3_decode_memory expected 'usize_t *' {aka 'unsigned int *'} but argument is of type 'uint64_t *' {aka 'long long unsigned int *'} #15963

Closed
MSHectorCM opened this issue Nov 29, 2023 · 7 comments

Comments

@MSHectorCM
Copy link

Description

Building retroarch I'm facing the error

tasks/task_patch.c: In function 'xdelta_apply_patch':
tasks/task_patch.c:695:25: warning: passing argument 6 of 'xd3_decode_memory' from incompatible pointer type [-Wincompatible-pointer-types]
695 | *targetdata, targetlength, *targetlength, 0))
| ^~~~~~~~~~~~
| |
| uint64_t * {aka long long unsigned int *}
tasks/../deps/xdelta3/xdelta3.h:1163:43: note: expected 'usize_t *' {aka 'unsigned int *'} but argument is of type 'uint64_t ' {aka 'long long unsigned int '}
1163 | usize_t output_size,
| ~~~~~~~~~~~~~~~^~~~~~~~~~~
make[1]: Leaving directory '/
/build/lib32-retroarch-0ffd3030bf6d76edfa9155bdacffcf81d009fbdf'

Expected behavior

To Compile with no errors

Actual behavior

error due to mismatch of types

Steps to reproduce the bug

Compiling against Emuelec toolchain

Bisect Results

The issue started on this commit cbf49a0

Version/Commit

Starting commit cbf49a0 and onwards

Environment information

  • OS: EMUELEC 4.7 toolchain compiling on Ubuntu 20.04 WSÑ2
  • Compiler: gcc 12
@JesseTG
Copy link
Contributor

JesseTG commented Nov 29, 2023

Are you trying to produce a 32-bit build, per chance?

@MSHectorCM
Copy link
Author

The system is 64 bit but there is a part that is 32 bit and it is failing due to the uint64. Is it possible having uint32 or any other workaround?

thx!!!

@JesseTG
Copy link
Contributor

JesseTG commented Nov 29, 2023

If I understand correctly, you're trying to build a 32-bit instance of RetroArch to run on a 64-bit system? If that's the case, is there a reason you can't use a native 64-bit build?

@MSHectorCM
Copy link
Author

MSHectorCM commented Nov 29, 2023

yes it is, but I don't why it is failing with that type. It should work. We are using both 64bit and 32 bit.

@JesseTG
Copy link
Contributor

JesseTG commented Nov 30, 2023

@MSHectorCM Does this PR resolve your issue?

@Kelvfimer
Copy link

I need to check @JesseTG :) thx for your support

@MSHectorCM
Copy link
Author

Hello @JesseTG thx it is solved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants