Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Menu sub label finetunes and file names in on-screen notifications #16146

Open
davidhedlund opened this issue Jan 20, 2024 · 10 comments
Open

Comments

@davidhedlund
Copy link
Contributor

davidhedlund commented Jan 20, 2024

Sub-labels

Settings

Replace "file browser" with "File Browser":

  • Settings -> User Interface -> File Browser -> Filter Unknown Extensions: "Filter files being shown in the file browser..."
  • Settings -> User Interface -> File Browser -> Remember Last Used Start Directory: "Open the file browser..."

Add sub-label "(Restart required)":

  • Settings -> Input -> Maximum Users

Rename "Save Configuration on Quit" to "Save Configuration on Quit for this Session"

"Requires restart" sub-label

Asked in #16146 (comment)

"These are all entries in "Settings -> Drivers". Can someone please answer which one that should have the sub-label "Requires restart.", because I don't know how to test them?:

  • Menu: Has "Requires restart."
  • Video: Yes/no?
  • Audio: Yes/no?
  • Microphone: Yes/no?
  • Input: Yes/no?
  • Controller: Yes -- Confirmed by me
  • Record: Yes/no?
  • MIDI: Yes/no?
  • Camera: Yes/no?
  • Location: Yes/no?"

When the "Controller" entry has "Requires restart", document that we encourage users to generate and upload autoconfig files for all controller drivers at libretro/docs#910

Quick Menu

The requirement is not added, it is: "Requires first that file(s) has been saved via option(s) at 'Controls -> Manage Remap Files'.":

  • Settings -> Configuration -> Save Remap Files on Quit: "Save changes to any active input remap file when closing content or quitting RetroArch."

Missing directories in Settings -> Directory

core_options_path

core_options_path = ""

  • Recommended sub-label: "A default path will be assigned if not set. If set, the directory for retroarch-core-options.cfg (requires "Settings -> Configuration -> Use Global Core Options File" enabled [if global_core_options = "true" add: " (done)"]"

Replace in https://github.com/libretro/RetroArch/blob/master/retroarch.cfg

# Path to core options config file.
# This config file is used to expose core-specific options.
# It will be written to by RetroArch.
# A default path will be assigned if not set.
# core_options_path =

with

# Path to core options config file.
# This config file is used to expose core-specific options.
# It will be written to by RetroArch.
# A default path will be assigned if not set.
# This setting depends on
#   global_core_options = "true"
# core_options_path =

video_font_path

video_font_path = ""

# Path to a font used for rendering messages. This path must be defined to enable fonts.
# Do note that the _full_ path of the font is necessary!
# video_font_path =

video_font_path is set to video_font_path = "" for the Flatpak package, and the Appimage.

Document

Comment these variables in https://github.com/libretro/RetroArch/blob/master/retroarch.cfg

bundle_assets_dst_path = ""

  • "Bundle_assets dirs are used, but that should probably not be user configurable."

bundle_assets_src_path = ""`

  • "Bundle_assets dirs are used, but that should probably not be user configurable."

See also

Done

Replace "system directory" with "System/BIOS directory":

cursor_directory = "/app/share/libretro/database/cursors"

resampler_directory = ""

Replace "DualAnalog" with "Dual Analog":

  • Controls -> Port * Controls -> Device Type: "DualAnalog"
  • Note: To make the "DualAnalog" option visible, you have to load a PlayStation core with a game
  • "DualAnalog is coming from the core(s) directly, so that does not depend on RA". Submitted to https://github.com/OpenEmu/Mednafen-Core/issues/36

Shaders -> Prepend Preset / Append Preset (solved via https://github.com/libretro/RetroArch/pull/16095/files)

  • Both are using identical sub-label "Append preset to the currently loaded preset." which makes it difficult to distinguish them.

Per zoltanvb@ee9e68c and 14ce660 :

  • Settings -> User Interface -> File Browser: "Change file browser settings." <-- s/file browser/File Browser/
  • Settings -> User Interface -> File Browser-> Show Hidden Files and Directories: "Show hidden files and directories in the file browser." <-- s/file browser/File Browser/
  • Settings -> User Interface -> Menu Item Visibility -> [9 entries] : "* (Restart Required on Ozone/XMB)" <-- s/(Restart Required on Ozone/XMB)/ (Restart required on Ozone/XMB)./
  • Settings -> User Interface -> Menu: "Menu driver to use. Requires restart." <-- s/Requires restart/ (Restart required)// -- to indicate Main Menu -> Restart. See more info here.

Per https://github.com/libretro/RetroArch/pull/16144/files

  • Settings -> Directory -> File Browser: "Set Start Directory for the File Browser"

Per #16121

  • Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile

Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.16.0

Environment information

  • OS: Any
  • Compiler: [In case you are running local builds]
@davidhedlund davidhedlund changed the title [Menu] Quick Menu entries: Add file path and file name to the pop-up notifications [Menu] Quick Menu Save/Load/Remove entries: Add file path and file name to the pop-up notifications Jan 20, 2024
@davidhedlund davidhedlund changed the title [Menu] Quick Menu Save/Load/Remove entries: Add file path and file name to the pop-up notifications [Menu] Save/Load/Remove entries: Add file path and file name to the pop-up notifications Jan 20, 2024
@davidhedlund davidhedlund changed the title [Menu] Save/Load/Remove entries: Add file path and file name to the pop-up notifications [Menu] Menu sub label finetunes and file names in on-screen notifications Jan 20, 2024
@hizzlekizzle
Copy link
Contributor

Main Menu -> Online Updater -> Updater Settings -> On-Demand Thumbnail Downloads: "Automatically download missing thumbnails while browsing playlists" <-- s/playlists/the Playlists directory/
Main Menu -> Online Updater -> Information -> Database Manager: "View databases." <-- s/View databases/View files in the Database directory/

I disagree with these. In neither case are you browsing the directory. You're browsing the contents of the files.

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets. I suggest including the full path in the logs if they're not already, though.

@davidhedlund
Copy link
Contributor Author

davidhedlund commented Jan 20, 2024

Main Menu -> Online Updater -> Updater Settings -> On-Demand Thumbnail Downloads: "Automatically download missing thumbnails while browsing playlists" <-- s/playlists/the Playlists directory/
Main Menu -> Online Updater -> Information -> Database Manager: "View databases." <-- s/View databases/View files in the Database directory/

I disagree with these. In neither case are you browsing the directory. You're browsing the contents of the files.

I removed them, thank you for reading through the whole list!

Do you prefer single quotes or not?:

  • Change 'File Browser' settings. or
  • Change File Browser settings.

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets.

We could add just file names (like for the Online Updater -> Update Assets -> Update * entries) to begin with. Also, the file names are not fully included currently. I just submitted:

@davidhedlund
Copy link
Contributor Author

davidhedlund commented Jan 20, 2024

@zoltanvb Please participate in this issue if you want, since you commited:

@hizzlekizzle
Copy link
Contributor

I'd probably go with no quotes, since that sort of thing can be difficult to convey in translations.

@davidhedlund
Copy link
Contributor Author

While I like the idea of including the full paths, there's no way most full paths are going to fit in the notification widgets. I suggest including the full path in the logs if they're not already, though.

I just submitted this, if you are interested:

zoltanvb added a commit to zoltanvb/RetroArch that referenced this issue Feb 23, 2024
@davidhedlund
Copy link
Contributor Author

@zoltanvb I updated all entries in the top post:

  • Made all text significantly more readable.
  • Merged fixed entries under the "Done" section

@zoltanvb
Copy link
Contributor

zoltanvb commented Mar 1, 2024

Prepend sublabel was fixed by #16095.
Resampler directory seems unused nowadays, can probably be removed from the code.
Video font directory gets initialized when browsing for a new font so probably it is not needed to have it configurable separately.
Core options path is only used when global core options are enabled (and in that case it points to one file called retroarch-core-options.cfg).
Cursor directory is not used any more (views are saved next to playlists), few traces are still in the code that could be removed.
Bundle_assets dirs are used, but that should probably not be user configurable.
DualAnalog is coming from the core(s) directly, so that does not depend on RA,

@davidhedlund
Copy link
Contributor Author

@zoltanvb I updated all entries in the top post:

* Made all text significantly more readable.

* Merged fixed entries under the "Done" section

I repeated this with your new information. Thank you once again.

zoltanvb added a commit to zoltanvb/RetroArch that referenced this issue Mar 6, 2024
LibretroAdmin pushed a commit that referenced this issue Mar 6, 2024
@davidhedlund
Copy link
Contributor Author

Merged to the Done section in the top post: Replace "system directory" with "System/BIOS directory"

Thanks!

@davidhedlund
Copy link
Contributor Author

Found that "Maximum Users" requires restart to functioning, which should be added to its sub-label:

Settings -> Input -> Maximum Users
Sub-label: "[Current text ] (Restart required)"

Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this issue Dec 26, 2024
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this issue Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants