Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core overwrites savefile if SaveRAM Compression is enabled on RetroArch #41

Open
Ryunam opened this issue Jul 6, 2020 · 1 comment
Open

Comments

@Ryunam
Copy link

Ryunam commented Jul 6, 2020

As discussed yesterday in the libretro Discord server, it appears that this core in its current form is incompatible with the "SaveRAM Compression" functionality as implemented in RetroArch. This leads to an overwrite of the savefile upon launching any content, since the core does not recognize the .srm file in its compressed form.

Here's how to reproduce the issue:

  • Set "SaveRAM Compression" under Settings -> Saving in RetroArch to ON.
  • Load up any other SNES cores available (snes9x, Mesen-S, bsnes-mercury, etc.), then run any piece of content and save some progress, so that the change to the save is clearly identifiable (for instance in the file list after the title screen).
  • Now load this core or any of its variants available (for instance bsnes-hd beta), then run the same content previously used with the same .srm savefile. Any previously saved progress in the savefile will be gone.
@negativeExponent
Copy link

negativeExponent commented Aug 11, 2020

because this core do not support libretro api's retro_get_memory_data/size for sram/system ram access, the internal save function should not be using .srm as that file extension as that is reserved for libretro use... also RA should have sort savestates/saverams by folder/core names as default to avoid other core overriding another cores save file, just incase for some they are incompatible or in rare cases something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants