Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull common functionality out of treeburner into umbra #1

Open
simondevenish opened this issue Oct 27, 2022 · 4 comments
Open

Pull common functionality out of treeburner into umbra #1

simondevenish opened this issue Oct 27, 2022 · 4 comments

Comments

@simondevenish
Copy link

simondevenish commented Oct 27, 2022

treeburner contains a large collection of utilities and objects that can support the development of any roguelike game. With some treatment of these treeburner classes, the capability of umbra could be expanded into a general rougelike engine/toolkit by refactoring these tools out of treeburner into umbra

@HexDecimal
Copy link
Contributor

What I was doing was working on Umbra and it's sub-projects simultaneously, but this sounds like a better idea. The 3 projects using Umbra all share similar codebases, so it might work better to move the duplicate code to Umbra itself.

@simondevenish
Copy link
Author

@HexDecimal I presume we want to refactor umbra code into namespaces as I have done on treeburner

@simondevenish
Copy link
Author

That way treeburner code pulled into Umbra can be easily ported

@HexDecimal
Copy link
Contributor

Yeah. Especially since this is supposed to be included into other projects. All these headers used to have an umbra_ prefix before, but I didn't add a namespace.

I'd probably go with umbra:: for everything. Maybe also umbra::widget::. Not sure about imod, that needs to be unabbreviated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants