Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown render xkcd images #16463

Closed
ddugovic opened this issue Nov 23, 2024 · 1 comment · Fixed by #16466
Closed

Markdown render xkcd images #16463

ddugovic opened this issue Nov 23, 2024 · 1 comment · Fixed by #16466
Labels

Comments

@ddugovic
Copy link
Contributor

Exact URL of where the bug happened

https://lichess.org/forum/lichess-feedback/blocking-certain-blog-writers?page=2#11

Steps to reproduce the bug

  1. Type a comment including an image URL from imgs.xkcd.com (previous xkcd.com), for example:
I appreciate your enthusiasm but this feedback is deeply confusing.
https://imgs.xkcd.com/comics/constructive.png
  1. Submit

What did you expect to happen?

Image would display with comment

What happened instead?

image

Operating system

Windows 10

Browser and version (or alternate access method)

Vivaldi latest (Chromium-based)

Additional information

Searching lila code for xkcd https://github.com/search?q=repo%3Alichess-org%2Flila%20xkcd&type=code finds xkcd.com.
Perhaps Munroe changed their embedded image URL subdomain from https://xkcd.com to https://imgs.xkcd.com?

@SergioGlorias
Copy link
Member

Checking the forum, at least 6 years ago imgs.xkcd.com was already used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants