Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage Publish breaks CI on Fork PRs #443

Open
george-zubrienko opened this issue Jul 20, 2023 · 2 comments
Open

Code Coverage Publish breaks CI on Fork PRs #443

george-zubrienko opened this issue Jul 20, 2023 · 2 comments
Assignees
Labels
bug Something isn't working code/ci

Comments

@george-zubrienko
Copy link
Collaborator

Apparently GH Actions do not allow fork PR runs to post comments on parent repo. We should skip coverage publishing for forks as a quick workaround

community/community#25217 (comment)

@george-zubrienko george-zubrienko self-assigned this Jul 20, 2023
@george-zubrienko george-zubrienko added bug Something isn't working code/ci labels Jul 20, 2023
@george-zubrienko
Copy link
Collaborator Author

@lidatong there is a chance this can be fixed by this MishaKav/pytest-coverage-comment#68 (comment) - could you test? I honestly do not remember what fixed this in our OSS repos for forks, or if we ever fixed that at all

@george-zubrienko
Copy link
Collaborator Author

as an alternative, I can disable coverage comment with either hide-comment or by disabling the step with

if: ${{ !github.event.pull_request.head.repo.fork }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code/ci
Projects
None yet
Development

No branches or pull requests

1 participant