From dd6a97bf46cdba55e766beced3e8cd84447b498c Mon Sep 17 00:00:00 2001 From: lidezhu Date: Fri, 21 Feb 2025 19:22:35 +0800 Subject: [PATCH 1/2] add some log --- components/cdc/src/endpoint.rs | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/components/cdc/src/endpoint.rs b/components/cdc/src/endpoint.rs index d5197684e13..e442af9d3e6 100644 --- a/components/cdc/src/endpoint.rs +++ b/components/cdc/src/endpoint.rs @@ -257,11 +257,13 @@ impl fmt::Debug for Task { .field("multi_batch", &multi.len()) .finish(), Task::MinTs { + ref regions, ref min_ts, ref current_ts, .. } => de - .field("type", &"mit_ts") + .field("type", &"min_ts") + .field("regions", ®ions) .field("current_ts", current_ts) .field("min_ts", min_ts) .finish(), @@ -1025,6 +1027,12 @@ impl, E: KvEngine, S: StoreRegionMeta> Endpoint self.resolved_region_count, + "unresolved_region_count" => self.unresolved_region_count, + ); + // Separate broadcasting outlier regions and normal regions, // so 1) downstreams know where they should send resolve lock requests, // and 2) resolved ts of normal regions does not fallback. @@ -1051,9 +1059,16 @@ impl, E: KvEngine, S: StoreRegionMeta> Endpoint (), + Ok(_) => { + for region in resolved_ts.get_regions() { + info!("cdc send event succeed"; + "conn_id" => ?conn.get_id(), + "downstream" => ?conn.get_peer(), + "region_id" => ?region); + } + }, Err(SendError::Disconnected) => { - debug!("cdc send event failed, disconnected"; + info!("cdc send event failed, disconnected"; "conn_id" => ?conn.get_id(), "downstream" => ?conn.get_peer()); } Err(SendError::Full) | Err(SendError::Congested) => { From aeb2b35c8f7ea3a1839ed8c9b71516624649f60a Mon Sep 17 00:00:00 2001 From: lidezhu Date: Fri, 21 Feb 2025 19:55:06 +0800 Subject: [PATCH 2/2] fix build --- components/cdc/src/endpoint.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/cdc/src/endpoint.rs b/components/cdc/src/endpoint.rs index e442af9d3e6..4b53ecae011 100644 --- a/components/cdc/src/endpoint.rs +++ b/components/cdc/src/endpoint.rs @@ -1052,7 +1052,7 @@ impl, E: KvEngine, S: StoreRegionMeta> Endpoint, E: KvEngine, S: StoreRegionMeta> Endpoint { - for region in resolved_ts.get_regions() { + for region in regions { info!("cdc send event succeed"; "conn_id" => ?conn.get_id(), "downstream" => ?conn.get_peer(),