Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended id3v1 test #66

Open
lieff opened this issue Mar 1, 2020 · 2 comments
Open

Extended id3v1 test #66

lieff opened this issue Mar 1, 2020 · 2 comments
Labels
test

Comments

@lieff
Copy link
Owner

lieff commented Mar 1, 2020

From #57 .
I did not find any software which writes it, so this path not tested yet.
@lieff lieff added the test label Mar 1, 2020
@sezero
Copy link

sezero commented Mar 27, 2021

It's a wannabee extension which no one uses, no player supports and
no tag library parses: It should be removed. (which I did so myself
in SDL_mixer quite some time ago.)

@lieff
Copy link
Owner Author

lieff commented Mar 28, 2021

Thanks :) That seems to be the best way to solve this problem.

@grhbit grhbit mentioned this issue Apr 12, 2021
Open
sezero referenced this issue in libsdl-org/SDL_mixer Jan 14, 2024
@slouken
Revert "Use dr_mp3 instead of minimp3 for default MP3 support"
c3e80e7 
This reverts commit c94f6ce.

minimp3 supports LAME tags for more precise seeking and length information

Fixes #439
sezero added a commit to sezero/SDL_mixer that referenced this issue Jan 14, 2024
@sezero
minimp3: remove TAG+ support
74e86d6 
It's a still-born extension that no one uses, no player
supports, and no tag library parses.

And it's not impossible to hit it as a false positive..

(The removal has already been suggested to mainstream at
lieff/minimp3#66)
@sezero sezero mentioned this issue Jan 14, 2024
Merged
slouken pushed a commit to libsdl-org/SDL_mixer that referenced this issue Jan 14, 2024
@sezero @slouken
minimp3: remove TAG+ support
f9933b5 
It's a still-born extension that no one uses, no player
supports, and no tag library parses.

And it's not impossible to hit it as a false positive..

(The removal has already been suggested to mainstream at
lieff/minimp3#66)
slouken pushed a commit to libsdl-org/SDL_mixer that referenced this issue Jan 14, 2024
@sezero @slouken
minimp3: remove TAG+ support
532013b 
It's a still-born extension that no one uses, no player
supports, and no tag library parses.

And it's not impossible to hit it as a false positive..

(The removal has already been suggested to mainstream at
lieff/minimp3#66)

(cherry picked from commit f9933b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sezero @lieff