Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported simple support for BIMI indicators #414

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Nov 19, 2023

No description provided.

@dodmi
Copy link
Contributor Author

dodmi commented Nov 19, 2023

Can you help me a little?
It' working, but I don't know how to fix the Type Check errors :(

@lieser
Copy link
Owner

lieser commented Nov 20, 2023

The problem is that TypeScript does not understand the Mozilla specific module system used here (The jsm files with EXPORTED_SYMBOLS and the Cu.import(...) calls).
The result is that it treats them as normal JavaScript files. And wrongly assumes they share the same scope.

Two possible workarounds would be:

@dodmi dodmi force-pushed the backport-features-5-2.x-bimi-2023-11-19 branch 3 times, most recently from 9a9c861 to 81ded08 Compare November 20, 2023 19:28
@dodmi
Copy link
Contributor Author

dodmi commented Nov 20, 2023

Thank you, I did this and it seems to be fine now.

lieser
lieser previously approved these changes Nov 22, 2023
@lieser lieser added this to the 2.3.0 milestone Nov 22, 2023
modules/bimi.jsm.js Outdated Show resolved Hide resolved
@dodmi dodmi force-pushed the backport-features-5-2.x-bimi-2023-11-19 branch 2 times, most recently from f1e87a1 to 7d61dac Compare November 23, 2023 18:57
@lieser
Copy link
Owner

lieser commented Nov 23, 2023

Note that this PR has a conflict that needs to be resolved.

@dodmi
Copy link
Contributor Author

dodmi commented Nov 24, 2023

Note that this PR has a conflict that needs to be resolved.

Well yes, in this PR DKIM_InternalError is still used. I‘ll fix it.

@dodmi dodmi force-pushed the backport-features-5-2.x-bimi-2023-11-19 branch from 7d61dac to 2d56b4e Compare November 27, 2023 16:01
@lieser lieser merged commit 9c939f1 into lieser:2.x Nov 30, 2023
2 checks passed
@dodmi dodmi deleted the backport-features-5-2.x-bimi-2023-11-19 branch November 30, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants