Backport feature detailed results 5 to 2x #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: data/favicon.json new file: data/favicon/congenio.de.png modified: data/signersDefault.json modified: modules/dkimVerifier.jsm.js modified: modules/helper.jsm.js
dodmi
force-pushed
the
backport-feature-detailed-results-5-2x
branch
from
1620476 to
f77bd62
Compare
|
Thanks for back porting this work in progress. I will try to find time this weekend to continue the work on this for 5.x, and also more closely look at your back port. |
|
Feel free to use parts of my code or let me know if I should change/improve something. I'm pretty happy, but I have no solution for cut tooltips. But this isn't a problem for one or two signatures, which is the usual amount, as I can easily see now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a pull request for my backport of displaying detailed results. So you can see the code matching the screenshots.
I'm pretty happy with the output, now. But I'm unhappy, how I solved the GUI part in chrome/content/dkim.js.
I don't really understand your code in bindings.xml (or custom XUL elements in general). So my implementation is pretty ugly and probably needs some improvement.
The clean way would probably be extending bindings.xml and not manipulating DOM objects directly...