feat(@clayui/css): Adds :focus-visible support #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM! @pat270 how is the use case when we have the focus visible together with the c-inner, does it cause any problems? It would be possible for example to have a toggle, for example if the enable-focus-visible property is enabled the enable-c-inner property is disabled.
|
@pat270 I sent a small fix on the breadcrumb that we were using the I noticed that some use cases still have the ring perhaps this is expected for the Picker button, right?. I also noticed that we still have the ring in MultiStep. |
|
Thanks @matuzalemsteles ! I probably missed several places. I only updated the mixins. I should check the components as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
:focus-visiblesupport by default. All the browsers that we support have this feature, we can disable it by setting$enable-focus-visible: false. Most items should be covered except forminputandselect, these always show the focus outline.This also adds the class
c-prefers-focusto force focus on click via the accessibility menu. I wanted to include docs today, but couldn't get to it today.Lastly, I didn't cover the style issues in #5624. I feel like it's too much change for this PR.
#3342 #4972 #5006
@ethib137 @matuzalemsteles @marcoscv-work @veroglez