Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all CANSparkMax constructors to SparkMaxWrapper #22

Open
coachFitz0807 opened this issue Jan 22, 2021 · 1 comment
Open

Replace all CANSparkMax constructors to SparkMaxWrapper #22

coachFitz0807 opened this issue Jan 22, 2021 · 1 comment

Comments

@coachFitz0807
Copy link
Contributor

In the 2020 repo, we changed the DriveTrain to use the new SparkMaxWrapper so the DriveTrain wuld work with the simulator. We should also change the other CANSparkMax devices to use the SparkMaxWrapper as well. The simulator doesn't, yet, support simulating the mechanisms for which we use them, but at least it will get rid of the error messages we see in the simulator log.

@prensing
Copy link
Member

Actually, I think there is a rumor that the new library from Rev might support the simulation (similar for the navX). So, we should not change code until we update and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants