Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_ESPLORA_SERVER_URL is not useful for networks other than Network::Bitcoin #424

Open
rustaceanrob opened this issue Jan 2, 2025 · 1 comment

Comments

@rustaceanrob
Copy link
Contributor

Calling Builder::set_network without changing the chain source will result in a Network::Bitcoin configuration for the chain source, using the mainnet Esplora server, but a test network wallet that will never sync. IMO there should be an error added to build error that reflects this network mismatch.

@tnull
Copy link
Collaborator

tnull commented Jan 3, 2025

Calling Builder::set_network without changing the chain source will result in a Network::Bitcoin configuration for the chain source, using the mainnet Esplora server, but a test network wallet that will never sync. IMO there should be an error added to build error that reflects this network mismatch.

Hmm, there is no way to tell from the set URL for which network it is. We currently simply expect users to change the chain source to their liking whenever they also switch the network.

One solution might be to disallow setting the network independently from the chain source. If we do this, we probably should do it in conjuction with #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants