Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new store for inbound payment metadata #425

Open
tnull opened this issue Jan 3, 2025 · 0 comments
Open

Add new store for inbound payment metadata #425

tnull opened this issue Jan 3, 2025 · 0 comments
Milestone

Comments

@tnull
Copy link
Collaborator

tnull commented Jan 3, 2025

Prior to v0.1 LDK only offered PaymentIds for outbound payments, which led us to track inbound payments by an ID derived for the payment hash. This was always messy as the latter is only available for BOLT11 payments, resulting in BOLT11 payments being added to the payment store upon invoice creation, and BOLT12 payments only being added upon receiving the invoice request.

With lightningdevkit/rust-lightning#3303 LDK added PaymentIds for inbound payments, so we should switch to use them in a backwards-compatible manner (i.e., probably still checking whether the old-style ID is available in the store for now). However, as this will mean we that we can't add the payment store entry upon invoice creation also for BOLT11 payments, we finally need a different solution to store additional metadata (invoices, but also JIT-channel fee limits) before receiving the payment. That is we need to add a PaymentMetatdataStore or similar.

@tnull tnull added this to the 0.5 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant