Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlc: bump version to v1.25.0 #128

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

positiveblue
Copy link
Contributor

Since v0.18.0 there they multiple bug fixes, support more postgres/sqlite features, etc...

Nothing impacting the current code.

NOTE: It also looks like sqlc is growing as a company and wants to support more languages, add feature for cloud clients, etc... Because of the open source nature of this project I do not think that brings any extra benefit. The only remarkable thing is that they are working on doing the code more modular, and extracting the code generation in multiple "plugins" They already extracted the go one. No changes are needed by now, but maybe at some point they delete the code gen form the main project and the config files need to be updated to use the plugin system [sqlc-dev/plugin-sdk-go].

Since v0.18.0 there they multiple bug fixes, support more postgres/sqlite
features, etc...

Nothing impacting the current code.

NOTE: It also looks like sqlc is growing as a company and wants to support
more languages, add feature for cloud clients, etc... Because of the
open source nature of this project I do not think that brings any extra
benefit. The only remarkable thing is that they are working on doing the
code more modular, and extracting the code generation in multiple "plugins"
They already extracted the go one. No changes are needed by now, but maybe
at some point they delete the code gen form the main project and the config
files need to be updated to use the plugin system [sqlc-dev/plugin-sdk-go].
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@Roasbeef Roasbeef merged commit 5aa7aa2 into lightninglabs:master Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants