Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade go to v1.23.1 #152

Closed
wants to merge 2 commits into from

Conversation

jbrill
Copy link

@jbrill jbrill commented Oct 14, 2024

When building aperture I'm receiving:

4.151 OK: 213 MiB in 51 packages
4.184 Cloning into '/go/src/github.com/lightninglabs/aperture'...
4.843 Already on 'master'
4.843 Your branch is up to date with 'origin/master'.
4.855 go: errors parsing go.mod:
4.855 /go/src/github.com/lightninglabs/aperture/go.mod:3: invalid go version '1.22.6': must match format 1.23
4.855 /go/src/github.com/lightninglabs/aperture/go.mod:5: unknown directive: toolchain
4.857 go install -v github.com/lightninglabs/aperture/cmd/aperture
4.859 go: errors parsing go.mod:
4.859 /go/src/github.com/lightninglabs/aperture/go.mod:3: invalid go version '1.22.6': must match format 1.23
4.859 /go/src/github.com/lightninglabs/aperture/go.mod:5: unknown directive: toolchain
4.859 make: *** [Makefile:61: install] Error 1
------

This PR upgrades the Dockerfile to use v1.23.1-alpine.

@jbrill jbrill marked this pull request as draft October 14, 2024 17:47
@jbrill jbrill force-pushed the upgrade-go-1.23.1 branch from c087eb0 to 9c54697 Compare October 14, 2024 18:17
@jbrill
Copy link
Author

jbrill commented Oct 14, 2024

Closing for now as golangci-lint does not yet support v1.23.1

@jbrill jbrill closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant