itest: expect failure on direct rfq peer btc invoices #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Dec 11, 2024
| t.t, charlie, dave, dave, 20_000, assetID, withSmallShards(), | ||
| withFailure(lnrpc.Payment_FAILED, lnrpc.PaymentFailureReason_FAILURE_REASON_INCORRECT_PAYMENT_DETAILS), |
There was a problem hiding this comment.
lll, here and below. Can use failureIncorrectDetails that's defined in assets_test.go instead.
interesting, could be flaky, didn't hit this on local tests |
|
also linter seems to fail here with passes locally |
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
dd49654 to
890764a
Compare
Previously we'd consider it acceptable to settle direct rfq peer invoices, which included no rfq scid, with asset HTLCs. This behavior has been updated on the tapd invoice manager and we no longer accept asset HTLCs on invoices that do not expect assets. This commit updates such payments in our itests to instead expect a failure.
ffranr
reviewed
Dec 12, 2024
|
thanks @ffranr , currently working on resolving an error with the htlc force-close test, will push once it has been resolved |
GeorgeTsagk
force-pushed
the
strict-forwarding-p2-itest
branch
from
32daefb to
19fd405
Compare
guggero
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we'd consider it acceptable to settle direct rfq peer
invoices, which included no rfq scid, with asset HTLCs. This behavior
has been updated on the tapd invoice manager and we no longer accept
asset HTLCs on invoices that do not expect assets. This commit updates
such payments in our itests to instead expect a failure.
Tapd dependency: lightninglabs/taproot-assets#1244
Lnd dependency: lightningnetwork/lnd#9357