Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new "Requires Plugins" header to the Wetu Importer plugin to indicate the Tour Operator plugin dependency #172

Open
ashleyshaw opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
[Status] Needs Dev Ready for, and needs developer efforts [Status] Needs More Info Follow-up required in order to be actionable. [Type] Feature New feature to highlight in changelogs
Milestone

Comments

@ashleyshaw
Copy link
Member

ashleyshaw commented Oct 9, 2024

Add Plugin Dependency for Wetu Importer Add-On

Description:

The LSX Importer for Wetu plugin should indicate that it requires the Tour Operator plugin to be installed and active for proper functionality. The plugin header should include the new Requires Plugins field to enforce this dependency and prevent activation if the core Tour Operator plugin is missing.

Requirements:

  • Add a Requires Plugins field in the header to indicate dependency on the Tour Operator plugin.
  • Implement a dependency check using the WP_Plugin_Dependencies class.
  • Display an admin notice if the Tour Operator plugin is not installed or active.
  • Prevent activation of the Wetu Importer plugin if the dependency is unmet.
  • Implement a dependency check using the WP_Plugin_Dependencies class to verify that the Tour Operator plugin is installed and active.
  • Display an admin notice if the Tour Operator plugin is not installed, informing the user that it is required for the Where To Importer to work.
  • Prevent the activation of the Where To Importer if the Tour Operator plugin is not active.

Technical References:

  • Utilize the WP_Plugin_Dependencies class to manage plugin dependencies and ensure proper plugin loading behavior.

Code Snippet:

/*
 * Requires Plugins: tour-operator
 */

Acceptance Criteria:

  • When attempting to activate the Where To Importer, it should check if the Tour Operator plugin is installed and active using WP_Plugin_Dependencies.
  • An informative admin notice should appear if the dependency is not met.
  • The Where To Importer add-on should deactivate automatically if the Tour Operator plugin is missing or deactivated.
@ashleyshaw ashleyshaw added [Type] Feature New feature to highlight in changelogs [Status] Needs More Info Follow-up required in order to be actionable. [Status] Needs Dev Ready for, and needs developer efforts labels Oct 9, 2024
@ashleyshaw ashleyshaw added this to the 2.0.0 milestone Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Tour Operator Oct 9, 2024
@ashleyshaw ashleyshaw changed the title Core class for installing plugin dependencies - class WP_Plugin_Dependencies {} Add Plugin Dependency for Where To Importer Add-On Oct 10, 2024
@ashleyshaw ashleyshaw changed the title Add Plugin Dependency for Where To Importer Add-On Add the new "Requires Plugins" header to the Wetu Importer plugin to indicate the Tour Operator plugin dependency Oct 10, 2024
@ashleyshaw ashleyshaw self-assigned this Dec 17, 2024
ZaredRogers added a commit that referenced this issue Dec 17, 2024
Updated the Wetu Importer plugin header to include all necessary fields. This solves #171 and #172 

Signed-off-by: Zared Rogers <[email protected]>
krugazul added a commit that referenced this issue Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Dev Ready for, and needs developer efforts [Status] Needs More Info Follow-up required in order to be actionable. [Type] Feature New feature to highlight in changelogs
Projects
Status: 📥 Needs Dev
Development

No branches or pull requests

3 participants