Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uri() method to the CentralDogma client. #618

Open
minwoox opened this issue Jul 14, 2021 · 3 comments
Open

Add uri() method to the CentralDogma client. #618

minwoox opened this issue Jul 14, 2021 · 3 comments

Comments

@minwoox
Copy link
Contributor

minwoox commented Jul 14, 2021

So that a user easily retrieve the URI of CentralDogma when the client is created using the Spring profile.

@injae-kim
Copy link

I'll try this issue!
I'll create PR until Feb 20, 2022

@minwoox
Copy link
Contributor Author

minwoox commented Feb 15, 2022

Oops sorry about the late reply. 😅
Have you started working on this?
We might add EndpointGroup instead of uri method if we decide to add Armeria dependency to centraldogma-client.
#673
So please stay tuned for the issue. 😄

@injae-kim
Copy link

We might add EndpointGroup instead of uri method if we decide to add Armeria dependency to centraldogma-client.

oh.. thanks for sharing! I'll take a look #673 issue and add comment on that issue.
(Before #673 issue is resolved, I stop my working about this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants