Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Picasso absolutely needed for Line SDK? #163

Open
halizton opened this issue Jan 31, 2024 · 0 comments
Open

Is Picasso absolutely needed for Line SDK? #163

halizton opened this issue Jan 31, 2024 · 0 comments

Comments

@halizton
Copy link

halizton commented Jan 31, 2024

This is more as a question or feature request instead of an issue.

What did you do?

We integrate Line SDK for login purpose and realized Line SDK bringing in the entire Picasso image loading library. We use glide to load images in our app. The introduction of Picasso SDK makes our final app bigger.

What did you expect?

While Line SDK is a light SDK for login purpose, it is surprising that it brings in Picasso. We searched Line SDK code base and realized there are only 2 use cases where Picasso is used to load typical images into ImageView with a place holder. So we are wondering if the Picasso SDK can be removed and Line SDK can use the typical BitmapFactory to load those 2 images.

https://github.com/search?q=repo%3Aline%2Fline-sdk-android+Picasso.get%28%29&type=code

What do you think and I can help making the change if you prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant