Parameters of discriminator optimizer

[felixfuyihui]

In open-universe/open_universe/networks/universe/universe_gan.py, line 415 to 417, the code
params_disc = list(self.loss_mrd.parameters()) + list(
self.loss_mrd.parameters()
)
seems to have some bugs.
If I'm correct, it should be:
params_disc = list(self.loss_mrd.parameters()) + list(
self.loss_mpd.parameters()
)

[fakufaku]

Ouch, it looks like the parameters of the mpd are never optimized...

Unfortunately, I don't have an environment where I can test the fix anymore.

If you can compare, could you please comment here with the result?

[felixfuyihui]

Ouch, it looks like the parameters of the mpd are never optimized...

Unfortunately, I don't have an environment where I can test the fix anymore.

If you can compare, could you please comment here with the result?

Thank you so much for your reply. I'm currently using the fixed code to train my model, but unfortunately I'm working on my own datasets. I may invite my student to do this in the future and keep you updated with the results.

[fakufaku]

I understand. Do you see a big difference with your data?

[felixfuyihui]

I understand. Do you see a big difference with your data?

I think yes since I mainly use URGENT data.