Improve bounding rect code #874
Conversation
Deprecate local_layout_rect method. Add global_layout_rect method.
PoignardAzur
changed the title
| @@ -75,18 +75,10 @@ fn compose_widget( | |||
| ); | |||
| let parent_bounding_rect = parent_state.bounding_rect; | |||
|
|
|||
| // This could be further optimized by more tightly clipping the child bounding rect according to the clip path. | |||
There was a problem hiding this comment.
This note about optimization is not present after the code was moved. Is it still a valid future thing to do?
There was a problem hiding this comment.
Or is that the new call to overlaps? Either way, the logic in this code has changed, so the PR title that this is just adding documentation starts to become misleading.
There was a problem hiding this comment.
Ah, you renamed it after I started looking at it.
There was a problem hiding this comment.
This note about optimization is not present after the code was moved. Is it still a valid future thing to do?
I'd have to ask @Philipp-M. I'm not sure the note about optimization made sense in the original PR. I'd rather remove it unless we can point at a specific optimization we expect to do.
Document concepts of "layout rect" and "bounding rect".
Deprecate
local_layout_rect()method.Add
global_layout_rect()method.Remove
transform_changed()method.Improve bounding rect merging code.
Tweak
TestHarness::mouse_move_to.Tweak WidgetState doc.