Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any interest in implementing the extended isolation forest version #58

Open
Marcus-Rosti opened this issue Nov 13, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@Marcus-Rosti
Copy link
Contributor

https://arxiv.org/abs/1811.02141

@jverbus jverbus self-assigned this Dec 17, 2024
@jverbus jverbus added the enhancement New feature or request label Dec 17, 2024
@jverbus
Copy link
Contributor

jverbus commented Dec 17, 2024

It would be nice to add the extended isolation forest (EIF) variation of the algorithm to this library. However, I do not have plans to do this in the near term.

If someone wants to contribute an implementation, I'd be happy to review a short tech spec doc (likely best to align on what changes will be made before starting coding) and subsequent PRs. To have it accepted, we'd need to make sure it meets the standard of quality of the existing library, including:

  1. Follows the style and structure of the existing library. Reuses and/or extends existing code in an elegant way.
  2. Has comprehensive unit tests.
  3. Has comprehensive validation on open datasets that match the results in the paper.
  4. Is well documented.

It would also be nice to include ONNX export capability for the EIF (like we have for the IF in this library), but this could be a nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants