csv testing and bug fixes #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joshmoore - sorry this took so long to review; I'd like to take a look and get it resolved. Unfortunately, I don't have permission here to resolve the conflicts. (thank you for giving maintainers access to the PR - I am not sure why I can't resolve the conflicts with that permission but the button is unavailable to me). Can you resolve the conflicts here? Then I can walk through and get the tests passing. Thanks in advance! |
|
@sierra-moxon, no worries (though odd): done. |
|
It looks like this has gone stale while waiting to be reviewed |
|
Please let me know if there's something needed from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily adds the test cases mentioned under linkml/linkml#947. In debugging, there were a number of locations where an explicit
Nonecheck helped with determining what was wrong which I've included. Please let me know if those should be separated out.Note: this is currently failing both for all attributes as well as all slots with: