Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPath support #12

Open
Lco4eDb2 opened this issue Aug 31, 2023 · 6 comments
Open

XPath support #12

Lco4eDb2 opened this issue Aug 31, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Lco4eDb2
Copy link

Support for finding elements by XPath?

@lino-levan
Copy link
Owner

Makes sense to me. Was waiting for someone to ask to implement this.

@lino-levan lino-levan added the enhancement New feature or request label Sep 4, 2023
@lino-levan
Copy link
Owner

This isn't particularly challenging but it is making me rethink the API. Puppeteer and Playwright have entirely different APIs on this front. I tend to air towards Playwright when that happens but I've already started down a path which is closer to Puppeteer. This would probably require a breaking change to fix.

This is to say: I haven't forgotten this issue! It's just not super clear how to approach.

@lino-levan lino-levan added this to the 0.3.0 milestone Oct 10, 2023
@lino-levan lino-levan modified the milestones: 0.3.0, 0.4.0 Oct 18, 2023
@Lco4eDb2
Copy link
Author

Lco4eDb2 commented Feb 5, 2024

have you made any progress on this one? also, do you need any help with it?

@lino-levan
Copy link
Owner

Unfortunately, I have not. This needs to be a breaking change to align us with playwright. If you'd like to pick it up, feel free!

@lino-levan lino-levan removed this from the 0.4.0 milestone May 23, 2024
@pixeleet
Copy link
Contributor

pixeleet commented Jun 12, 2024

So umm, can we just use document.evaluate here?
What would the implementation in the astral universe look like?

https://developer.mozilla.org/en-US/docs/Web/API/Document/evaluate

@lino-levan
Copy link
Owner

Internally, yep. That's exactly what puppeteer does iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants