lib: meson.build: restore libqrtr SONAME #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of `libqrtr` had `libqrtr.so.1` as their SONAME, while the current version have only `libqrtr.so`. This is problematic as previously built binaries using this lib will have to be rebuilt for this new version (or rather, re-linked, which is practically equivalent). This change ensures the SONAME is kept by setting the project version in the top-level `meson.build` and uses this string as the shared library version. In practice, the generated library filename is now `libqrtr.so.1.1` with SONAME still being `libqrtr.so.1`.
konradybcio
approved these changes
Apr 30, 2024
lumag
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
libqrtrhadlibqrtr.so.1as their SONAME, while the current version have onlylibqrtr.so. This is problematic as previously built binaries using this lib will have to be rebuilt for this new version (or rather, re-linked, which is practically equivalent).This change ensures the SONAME is kept by setting the project version in the top-level
meson.buildand uses this string as the shared library version.In practice, the generated library filename is now
libqrtr.so.1.1with SONAME still beinglibqrtr.so.1.